task: verify that accesspass.connection_count == 0#2585
Closed
ANISH-SR wants to merge 7 commits intomalbeclabs:mainfrom
Closed
task: verify that accesspass.connection_count == 0#2585ANISH-SR wants to merge 7 commits intomalbeclabs:mainfrom
ANISH-SR wants to merge 7 commits intomalbeclabs:mainfrom
Conversation
juan-malbeclabs
requested changes
Jan 9, 2026
Contributor
juan-malbeclabs
left a comment
juan-malbeclabs
left a comment
There was a problem hiding this comment.
Please, it’s important to add a regression test that validates the behavior of your change. Thank you very much.
smartcontract/programs/doublezero-serviceability/src/processors/accesspass/close.rs
Outdated
Show resolved
Hide resolved
ANISH-SR
force-pushed
the
verify-connection-count-2220
branch
from
39ccfb6 to
3c50b48
Compare
smartcontract/programs/doublezero-serviceability/src/processors/accesspass/close.rs
Outdated
Show resolved
Hide resolved
smartcontract/programs/doublezero-serviceability/src/processors/accesspass/close.rs
Show resolved
Hide resolved
smartcontract/programs/doublezero-serviceability/src/processors/accesspass/close.rs
Show resolved
Hide resolved
Contributor
Author
|
Working on the fixes asap! thanks @martinsander00 |
auto-merge was automatically disabled
January 20, 2026 14:06
Head branch was pushed to by a user without write access
martinsander00
approved these changes
Jan 20, 2026
ANISH-SR
force-pushed
the
verify-connection-count-2220
branch
3 times, most recently
from
75d78e4 to
a61abf5
Compare
Contributor
|
@ANISH-SR seems like now the last 3 are signed but the first 3 aren't. I think easiest way is to squash all and sign the new one |
Contributor
Author
got it! will do exactly that for both this and the other issue. ths :) |
Contributor
|
This one is also ready to go. We just need to sign/squash the first commits. Rn there are 3 unsigned |
Fixes malbeclabs#2412 Implements RFC-11 on chain activation for MulticastGroup entity - enabling on-chain IP allocation via ResourceExtension bitmaps. - Add `multicast_slot: u32` field to MulticastGroup account for tracking bitmap slot index (enables deallocation) - Modify `ActivateMulticastGroup` to optionally accept ResourceExtension account and allocate multicast_ip from bitmap - Extend authorization to allow `foundation_allowlist` members (in addition to `activator_authority_pk`) - Update SDK with `resource_extension_pubkey` parameter for `ActivateMulticastGroupCommand` - When no ResourceExtension account is provided, uses the legacy path (provided `multicast_ip`, `multicast_slot = u32::MAX`) - Deserialization defaults `multicast_slot` to `u32::MAX` for existing on-chain accounts verify that accesspass.connection_count == 0 Signed-off-by: ANISH-SR <rawatanish08@gmail.com> tests: add unit tests for the change Signed-off-by: ANISH-SR <rawatanish08@gmail.com>
Signed-off-by: ANISH-SR <rawatanish08@gmail.com>
ANISH-SR
force-pushed
the
verify-connection-count-2220
branch
2 times, most recently
from
fa7c710 to
e6b45b1
Compare
smartcontract/programs/doublezero-serviceability/src/processors/accesspass/close.rs
Outdated
Show resolved
Hide resolved
martinsander00
approved these changes
Jan 26, 2026
Contributor
|
@ANISH-SR conflict :( |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Testing Verification
Resolves #2220